]> git.baikalelectronics.ru Git - kernel.git/commit
i40evf: dereference VSI after VSI has been null checked
authorColin Ian King <colin.king@canonical.com>
Mon, 20 Mar 2017 12:03:03 +0000 (12:03 +0000)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Mon, 27 Mar 2017 23:47:44 +0000 (16:47 -0700)
commit36ea9d5a547b7a63a5c7d2b388462a8c25ee7c3d
treea8a88790e807c4b7a58e3d7d9c8e4ff22238f936
parentd818cb2cfe514c2c3fcf6f61e8c6e83bfacede60
i40evf: dereference VSI after VSI has been null checked

VSI is being dereferenced before the VSI null check; if VSI is
null we end up with a null pointer dereference.  Fix this by
performing VSI deference after the VSI null check.  Also remove
the need for using adapter by using vsi->back->cinst.

Detected by CoverityScan, CID#1419696, CID#1419697
("Dereference before null check")

Fixes: fc6d9a3e694d99 ("i40evf: add client interface")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/i40evf/i40evf_client.c