]> git.baikalelectronics.ru Git - kernel.git/commit
clk: Fix clk_hw_get_clk() when dev is NULL
authorMaxime Ripard <maxime@cerno.tech>
Fri, 25 Feb 2022 14:35:23 +0000 (15:35 +0100)
committerStephen Boyd <sboyd@kernel.org>
Sat, 12 Mar 2022 03:01:35 +0000 (19:01 -0800)
commit36b669ed1a6cef01d19a699fc12d93c032e7b146
treee1206a21a7e11e031b320a4f8983cd7d2c2ba47a
parent3f9dbe488be4f82ab02dcbc37ea1fbf11cff9c83
clk: Fix clk_hw_get_clk() when dev is NULL

Any registered clk_core structure can have a NULL pointer in its dev
field. While never actually documented, this is evidenced by the wide
usage of clk_register and clk_hw_register with a NULL device pointer,
and the fact that the core of_clk_hw_register() function also passes a
NULL device pointer.

A call to clk_hw_get_clk() on a clk_hw struct whose clk_core is in that
case will result in a NULL pointer derefence when it calls dev_name() on
that NULL device pointer.

Add a test for this case and use NULL as the dev_id if the device
pointer is NULL.

Fixes: 172c5c952faa ("clk: add api to get clk consumer from clk_hw")
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://lore.kernel.org/r/20220225143534.405820-2-maxime@cerno.tech
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/clk.c