]> git.baikalelectronics.ru Git - kernel.git/commit
libata-sff: use WARN instead of BUG on illegal host state machine state
authorTejun Heo <tj@kernel.org>
Fri, 29 Jan 2016 12:06:53 +0000 (07:06 -0500)
committerTejun Heo <tj@kernel.org>
Fri, 29 Jan 2016 12:06:53 +0000 (07:06 -0500)
commit3688271692e5d9199c29ad344d2d4b8099f5ce7a
tree6aeda131112f26a167ab509cba70354376b60ba6
parent5aa0b73241d93d1b49f66ca3d35e93b3d152d482
libata-sff: use WARN instead of BUG on illegal host state machine state

ata_sff_hsm_move() triggers BUG if it sees a host state machine state
that it dind't expect.  The risk for data corruption when the
condition occurs is low as it's highly unlikely that it would lead to
spurious completion of commands.  The BUG occasionally triggered for
subtle race conditions in the driver.  Let's downgrade it to WARN so
that it doesn't kill the machine unnecessarily.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Dmitry Vyukov <dvyukov@google.com>
drivers/ata/libata-sff.c