]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: fix gen2-gen3 backlight set
authorJani Nikula <jani.nikula@intel.com>
Fri, 8 Nov 2013 14:48:57 +0000 (16:48 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 13 Nov 2013 10:16:22 +0000 (11:16 +0100)
commit3667cde943660267d365da5969000404b5418d42
tree1039455d99febbc4bf86f80ecb5384b08329160d
parent4a5a27f4e1eb7cebd9e2cfcd7aa83cb1db15db75
drm/i915: fix gen2-gen3 backlight set

Citing Jani's response to Imre's question in the review discussion:

> According to the gen2/3 bspec I have, the correct mask is
> BACKLIGHT_DUTY_CYCLE_MASK_PNV only in case of IS_PINEVIEW(dev), for
> everything else it's BACKLIGHT_DUTY_CYCLE_MASK.

What you say is correct, but we've treated all gen2/3 similar to PNV
since

commit c8dff62dae0d4d9ac67de25f3037cc823770a447
Author: Keith Packard <keithp@keithp.com>
Date:   Fri Nov 18 11:09:24 2011 -0800

    drm/i915: Treat pre-gen4 backlight duty cycle value consistently

i.e. we only use the high 15 bits for all gen2/3. For non-PNV this just
means the lowest bit is always zero. For PNV the lowest bit has a
different meaning in both the PWM freq and duty cycle fields.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
[danvet: Make the commit message less empty.]
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_panel.c