]> git.baikalelectronics.ru Git - kernel.git/commit
media: aspeed-video: address a protential usage of an unitialized var
authorMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Thu, 22 Aug 2019 14:46:40 +0000 (11:46 -0300)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Mon, 26 Aug 2019 17:03:39 +0000 (14:03 -0300)
commit35b35c1c0f748226761f5ff251760ee02dc7e968
treeca19285893c27214fac3f6a122cc950865bcdbac
parent0017287e64a356b3612ff1a0808ff71a818dc07d
media: aspeed-video: address a protential usage of an unitialized var

While this might not occur in practice, if the device is doing
the right thing, it would be teoretically be possible to have
both hsync_counter and vsync_counter negatives.

If this ever happen, ctrl will be undefined, but the driver
will still call:

aspeed_video_update(video, VE_CTRL, 0, ctrl);

Change the code to prevent this to happen.

This was warned by cppcheck:

[drivers/media/platform/aspeed-video.c:653]: (error) Uninitialized variable: ctrl

Reviewed-by: Eddie James <eajames@linux.ibm.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/aspeed-video.c