]> git.baikalelectronics.ru Git - kernel.git/commit
lan743x: fix "BUG: invalid wait context" when setting rx mode
authorSven Van Asbroeck <thesven73@gmail.com>
Mon, 9 Nov 2020 20:38:28 +0000 (15:38 -0500)
committerJakub Kicinski <kuba@kernel.org>
Wed, 11 Nov 2020 01:52:54 +0000 (17:52 -0800)
commit3525f3fa0e910ced441c866001a56cd38dd540d9
treeef8debe210f0685a3dee8af7902eb00ae3ea7818
parentb048d97be6a0e2e44af8f466aaa969bb7313a34c
lan743x: fix "BUG: invalid wait context" when setting rx mode

In the net core, the struct net_device_ops -> ndo_set_rx_mode()
callback is called with the dev->addr_list_lock spinlock held.

However, this driver's ndo_set_rx_mode callback eventually calls
lan743x_dp_write(), which acquires a mutex. Mutex acquisition
may sleep, and this is not allowed when holding a spinlock.

Fix by removing the dp_lock mutex entirely. Its purpose is to
prevent concurrent accesses to the data port. No concurrent
accesses are possible, because the dev->addr_list_lock
spinlock in the core only lets through one thread at a time.

Fixes: 6c21071c28d2 ("lan743x: Add main source files for new lan743x driver")
Signed-off-by: Sven Van Asbroeck <thesven73@gmail.com>
Link: https://lore.kernel.org/r/20201109203828.5115-1-TheSven73@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/microchip/lan743x_main.c
drivers/net/ethernet/microchip/lan743x_main.h