]> git.baikalelectronics.ru Git - kernel.git/commit
net/dim: Fix fixpoint divide exception in net_dim_stats_compare
authorTalat Batheesh <talatb@mellanox.com>
Wed, 17 Jan 2018 21:13:16 +0000 (23:13 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 19 Jan 2018 19:53:32 +0000 (14:53 -0500)
commit34ff0183da2bd5bc71cc84e8d03a8e5535a1429a
tree894a3fccfd3ca4555476dcbac1ba2e99485f4049
parente6240ee0aade620246c6b0e9f4ac835ea7703a60
net/dim: Fix fixpoint divide exception in net_dim_stats_compare

Helmut reported a bug about devision by zero while
running traffic and doing physical cable pull test.

When the cable unplugged the ppms become zero, so when
dividing the current ppms by the previous ppms in the
next dim iteration there is devision by zero.

This patch prevent this division for both ppms and epms.

Fixes: 06d22b806446 ("net/mlx5e: Added BW check for DIM decision mechanism")
Fixes: 2ea2b496e21f ("net/mlx5e: Move dynamic interrupt coalescing code to include/linux")
Reported-by: Helmut Grauer <helmut.grauer@de.ibm.com>
Signed-off-by: Talat Batheesh <talatb@mellanox.com>
Signed-off-by: Tal Gilboa <talgi@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/net_dim.h