]> git.baikalelectronics.ru Git - kernel.git/commit
dma-direct: Make DIRECT_MAPPING_ERROR viable for SWIOTLB
authorRobin Murphy <robin.murphy@arm.com>
Wed, 21 Nov 2018 16:00:50 +0000 (16:00 +0000)
committerChristoph Hellwig <hch@lst.de>
Wed, 21 Nov 2018 17:47:52 +0000 (18:47 +0100)
commit34b198f34bd0d3dc929800f70586bf9cd6ce74c7
tree94aba2a4c0adae46be45c150ff5a57f15805d882
parent041abd96ba41d7ca14769a68a64142415b69501b
dma-direct: Make DIRECT_MAPPING_ERROR viable for SWIOTLB

With the overflow buffer removed, we no longer have a unique address
which is guaranteed not to be a valid DMA target to use as an error
token. The DIRECT_MAPPING_ERROR value of 0 tries to at least represent
an unlikely DMA target, but unfortunately there are already SWIOTLB
users with DMA-able memory at physical address 0 which now gets falsely
treated as a mapping failure and leads to all manner of misbehaviour.

The best we can do to mitigate that is flip DIRECT_MAPPING_ERROR to the
other commonly-used error value of all-bits-set, since the last single
byte of memory is by far the least-likely-valid DMA target.

Fixes: 42ce474b98b5 ("swiotlb: remove the overflow buffer")
Reported-by: John Stultz <john.stultz@linaro.org>
Tested-by: John Stultz <john.stultz@linaro.org>
Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
include/linux/dma-direct.h