]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "libertas: add checks for the return value of sysfs_create_group"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 May 2021 11:57:19 +0000 (13:57 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 May 2021 16:32:31 +0000 (18:32 +0200)
commit34adf0f16b44a3520e2c5fb7dc996d207f0f8ff2
treec2a46b26cee844ee6f1da1f6fc30c989ca72a49a
parent71f736b7709881a52ccf4091419b53d35458ae4a
Revert "libertas: add checks for the return value of sysfs_create_group"

This reverts commit 4b9aaadd64c091aca27334259901b72db659e9c4.

Because of recent interactions with developers from @umn.edu, all
commits from them have been recently re-reviewed to ensure if they were
correct or not.

Upon review, this commit was found to be incorrect for the reasons
below, so it must be reverted.  It will be fixed up "correctly" in a
later kernel change.

The original commit was incorrect, the error needs to be propagated back
to the caller AND if the second group call fails, the first needs to be
removed.  There are much better ways to solve this, the driver should
NOT be calling sysfs_create_group() on its own as it is racing userspace
and loosing.

Cc: Kangjie Lu <kjlu@umn.edu>
Cc: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210503115736.2104747-53-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/wireless/marvell/libertas/mesh.c