]> git.baikalelectronics.ru Git - kernel.git/commit
bpf: Acquire map uref in .init_seq_private for sock{map,hash} iterator
authorHou Tao <houtao1@huawei.com>
Wed, 10 Aug 2022 08:05:33 +0000 (16:05 +0800)
committerAlexei Starovoitov <ast@kernel.org>
Wed, 10 Aug 2022 17:12:48 +0000 (10:12 -0700)
commit3492bd4399bd863327ebbbecae98b58172777742
tree6d2d2bbac610157cdfbeaa0538cb75e0f4b7b217
parent869a1582e50d2dec51c338ad71ce8b02395e0307
bpf: Acquire map uref in .init_seq_private for sock{map,hash} iterator

sock_map_iter_attach_target() acquires a map uref, and the uref may be
released before or in the middle of iterating map elements. For example,
the uref could be released in sock_map_iter_detach_target() as part of
bpf_link_release(), or could be released in bpf_map_put_with_uref() as
part of bpf_map_release().

Fixing it by acquiring an extra map uref in .init_seq_private and
releasing it in .fini_seq_private.

Fixes: 1b2deba5f45c ("net: Allow iterating sockmap and sockhash")
Signed-off-by: Hou Tao <houtao1@huawei.com>
Acked-by: Yonghong Song <yhs@fb.com>
Link: https://lore.kernel.org/r/20220810080538.1845898-5-houtao@huaweicloud.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
net/core/sock_map.c