]> git.baikalelectronics.ru Git - kernel.git/commit
tipc: initialize broadcast link stale counter correctly
authorJon Maloy <jon.maloy@ericsson.com>
Thu, 11 Oct 2018 20:02:29 +0000 (22:02 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 16 Oct 2018 05:03:34 +0000 (22:03 -0700)
commit32592cab28eecfcced2d0c717fb16709db7d071b
treeba81a3cb69ca6ac7fe4af9eb537091862d8da4b6
parentf939a16064d32ed92a378f409e6e4f7400ededf5
tipc: initialize broadcast link stale counter correctly

In the commit referred to below we added link tolerance as an additional
criteria for declaring broadcast transmission "stale" and resetting the
unicast links to the affected node.

Unfortunately, this 'improvement' introduced two bugs, which each and
one alone cause only limited problems, but combined lead to seemingly
stochastic unicast link resets, depending on the amount of broadcast
traffic transmitted.

The first issue, a missing initialization of the 'tolerance' field of
the receiver broadcast link, was recently fixed by commit 3c1be64c7492
("tipc: set link tolerance correctly in broadcast link").

Ths second issue, where we omit to reset the 'stale_cnt' field of
the same link after a 'stale' period is over, leads to this counter
accumulating over time, and in the absence of the 'tolerance' criteria
leads to the above described symptoms. This commit adds the missing
initialization.

Fixes: f0af99ef1f8a ("tipc: extend link reset criteria for stale packet retransmission")
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Acked-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tipc/link.c