]> git.baikalelectronics.ru Git - kernel.git/commit
USB HCD: avoid duplicate local_irq_disable()
authorAlan Stern <stern@rowland.harvard.edu>
Wed, 21 Nov 2007 23:13:10 +0000 (15:13 -0800)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 28 Nov 2007 21:58:35 +0000 (13:58 -0800)
commit31f199eddcfa38d93e8031a9bf68588a0d4813a3
treeb7e8512f25e22f8996dfcefbeb31ff6e7e7215e2
parent474400f4dec60d24251f125ed869a21082d82792
USB HCD: avoid duplicate local_irq_disable()

Arnd Bergmann wrote:

usb_hcd_flush_endpoint() has a retry loop that starts with a spin_lock_irq(),
but only gives up the spinlock, not the irq_disable before jumping to the
rescan label.

Alan Stern:

I agree with your sentiment, but it would be better to solve this
problem without using local_irq_disable().

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/core/hcd.c