]> git.baikalelectronics.ru Git - kernel.git/commit
iwlwifi: don't access a nonexistent register upon assert
authorEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Tue, 12 Apr 2016 10:07:52 +0000 (13:07 +0300)
committerLuca Coelho <luciano.coelho@intel.com>
Tue, 10 May 2016 19:34:05 +0000 (22:34 +0300)
commit311cba7620c99d06ef0f77b85697e310b968e5c3
tree3519066b52f8f4f4814dc2a147abcdab1a0ecb2e
parent7823c7c8f088f1f737b694f120b75258cf107fed
iwlwifi: don't access a nonexistent register upon assert

The commit below added code to dump the content of FIFOs
that are present only on dual CPU products (8000 and up).
This broke 7265D whose firmware does advertise
IWL_UCODE_TLV_CAPA_EXTEND_SHARED_MEM_CFG but doesn't have 2
CPUs. The current code does check the length of the FIFO
before dumping them (and the nonexistent FIFO has a 0
length), but we still accessed a register to set the FIFO
number and that made the DMA unhappy.

The impact was a much longer recovery upon firmware assert.

Fixes: 2e1db77fb782 ("iwlwifi: mvm: support dumping UMAC internal txfifos")
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/mvm/fw-dbg.c