]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915/gt: Avoid uninitialized use of rpcurupei in frequency_show
authorNathan Chancellor <natechancellor@gmail.com>
Wed, 29 Apr 2020 03:00:52 +0000 (20:00 -0700)
committerChris Wilson <chris@chris-wilson.co.uk>
Wed, 29 Apr 2020 06:46:21 +0000 (07:46 +0100)
commit2ea4a7ba9bf6e3bc1af899d1af481eb9b4ae8707
tree99055acbca7ec383f122ce20a34104c0c509c7e3
parentf6a7c21c991062da9ac93d547f07a5368c8d8d57
drm/i915/gt: Avoid uninitialized use of rpcurupei in frequency_show

When building with clang + -Wuninitialized:

drivers/gpu/drm/i915/gt/debugfs_gt_pm.c:407:7: warning: variable
'rpcurupei' is uninitialized when used here [-Wuninitialized]
                           rpcurupei,
                           ^~~~~~~~~
drivers/gpu/drm/i915/gt/debugfs_gt_pm.c:304:16: note: initialize the
variable 'rpcurupei' to silence this warning
                u32 rpcurupei, rpcurup, rpprevup;
                             ^
                              = 0
1 warning generated.

rpupei is assigned twice; based on the second argument to
intel_uncore_read, it seems this one should have been assigned to
rpcurupei.

Fixes: 9c878557b1eb ("drm/i915/gt: Use the RPM config register to determine clk frequencies")
Link: https://github.com/ClangBuiltLinux/linux/issues/1016
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20200429030051.920203-1-natechancellor@gmail.com
drivers/gpu/drm/i915/gt/debugfs_gt_pm.c