]> git.baikalelectronics.ru Git - kernel.git/commit
net: ethernet: ti: cpdma: correct error handling for chan create
authorIvan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Tue, 12 Dec 2017 21:06:35 +0000 (23:06 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 13 Dec 2017 20:49:53 +0000 (15:49 -0500)
commit2e961c9d95fc5fa90c3a1069a6549b6ba016434e
tree5027cd983a97970bcb3594fc13549a4efda82686
parent01db736b71a8e038eaf37b79d1f3fedc6dba6a36
net: ethernet: ti: cpdma: correct error handling for chan create

It's not correct to return NULL when that is actually an error and
function returns errors in any other wrong case. In the same time,
the cpsw driver and davinci emac doesn't check error case while
creating channel and it can miss actual error. Also remove WARNs
replacing them on dev_err msgs.

Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ti/cpsw.c
drivers/net/ethernet/ti/davinci_cpdma.c
drivers/net/ethernet/ti/davinci_emac.c