]> git.baikalelectronics.ru Git - kernel.git/commit
net/mlx5e: Set of completion request bit should not clear other adjacent bits
authorTariq Toukan <tariqt@mellanox.com>
Tue, 18 Feb 2020 10:27:25 +0000 (12:27 +0200)
committerSaeed Mahameed <saeedm@mellanox.com>
Mon, 20 Apr 2020 21:20:20 +0000 (14:20 -0700)
commit2e89daf693b202a67049681780cbd94e99bdd3c2
treeae1f43dea0b4fab8cf8d000ef5e4f3b38770809a
parent1982bee3c009afcd1838dff5b8b0efd7e37633c8
net/mlx5e: Set of completion request bit should not clear other adjacent bits

In notify HW (ring doorbell) flow, we set the bit to request a completion
on the TX descriptor.
When doing so, we should not unset other bits in the same byte.
Currently, this does not fix a real issue, as we still don't have a flow
where both MLX5_WQE_CTRL_CQ_UPDATE and any adjacent bit are set together.

Fixes: 67aa526836df ("net/mlx5e: Move helper functions to a new txrx datapath header")
Fixes: bf310cddbe42 ("net/mlx5e: Generalize tx helper functions for different SQ types")
Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
Reviewed-by: Aya Levin <ayal@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h