]> git.baikalelectronics.ru Git - kernel.git/commit
btrfs: remove redundant readonly root check in btrfs_setxattr_trans
authorAnand Jain <anand.jain@oracle.com>
Fri, 12 Apr 2019 08:02:57 +0000 (16:02 +0800)
committerDavid Sterba <dsterba@suse.com>
Mon, 29 Apr 2019 17:02:44 +0000 (19:02 +0200)
commit2e3c45375fdacbe31e25d85fe9e72a45ad054ee4
tree275cdb06503a91f3e451e7815f2e81eddf651503
parent3fb21e97bacaee977d1c5e0cb313ac364c87b8ae
btrfs: remove redundant readonly root check in btrfs_setxattr_trans

btrfs_setxattr_trans() is called by 5 functions as below and all of them
do updates. None of them would be roun on a read-only root.
So its ok to remove the readonly root check here as it's a high-level
conditon.

1.
  __btrfs_set_acl()
    btrfs_init_acl()
      btrfs_init_inode_security()

2.
  __btrfs_set_acl()
    btrfs_set_acl()

3.
  btrfs_set_prop()
    btrfs_set_prop_trans()
      /                       \
      btrfs_ioctl_setflags()   btrfs_xattr_handler_set_prop()

4.
  btrfs_xattr_handler_set()

5.
  btrfs_initxattrs()
    btrfs_xattr_security_init()
      btrfs_init_inode_security()

Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/xattr.c