]> git.baikalelectronics.ru Git - kernel.git/commit
target: Remove max_sectors device attribute for modern se_task less code
authorNicholas Bellinger <nab@linux-iscsi.org>
Wed, 9 May 2012 19:42:09 +0000 (12:42 -0700)
committerNicholas Bellinger <nab@linux-iscsi.org>
Wed, 9 May 2012 22:08:47 +0000 (15:08 -0700)
commit2e38ff0a35d1b5e1266dac0c0d1302a9a70a90a4
treefa753a950d19c2ef848c50c60f71019dcb912e74
parente204ed72517b8058974f37b2e9accd4df9468634
target: Remove max_sectors device attribute for modern se_task less code

This patch removes the original usage of dev_attr->max_sectors in favor of
dev_attr->hw_max_sectors that is now being enforced by target core from
within transport_generic_cmd_sequencer() for SCF_SCSI_DATA_SG_IO_CDB ops.

After the recent se_task removal patches from hch, this value for IBLOCK
backends being set via configfs by userspace from an saved max_sectors
value that is turning out to be problematic, so it makes sense to go ahead
and remove this now legacy attribute all-together.

This patch also continues to make se_dev_set_default_attribs() do
(sectors / block_size) alignment for what actually get used by
target_core_mod to be safe here, following the same alignment currently
used by fabric_max_sectors.

Reported-by: Andy Grover <agrover@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Roland Dreier <roland@purestorage.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/target_core_cdb.c
drivers/target/target_core_configfs.c
drivers/target/target_core_device.c
drivers/target/target_core_transport.c
include/target/target_core_base.h