]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Disable dp aux irq on g4x
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 7 Feb 2014 15:33:20 +0000 (16:33 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 7 Feb 2014 15:40:07 +0000 (16:40 +0100)
commit2ca062472b254610476fc3c9f8ba90aa5846398f
tree8611fed476ff604f35fce19a31c4e55fb48e4096
parent2971d55eb5e81ef8447bcfc42c4464dbe1526b26
drm/i915: Disable dp aux irq on g4x

Apparently it's broken in the exact same way as the gmbus irq. For
reference of the full story see

commit e39017f97daa02b4372e773ebea5ba9de91e9529
Author: Jiri Kosina <jkosina@suse.cz>
Date:   Tue Mar 19 09:56:57 2013 +0100

    drm/i915: stop using GMBUS IRQs on Gen4 chips

The effect is that we have a storm of unclaimed interrupts on the
legacy irq line. If that one is used by a different device then the
kernel will complain and rather quickly kill the irq source. Which
breaks any device trying to actually use the legacy irq line.

This regression has been introduced

commit cd080a7e5c59d31345c0a27a287d2916757bedc0
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Thu Oct 31 09:53:36 2013 +0100

    drm/i915: dp aux irq support for g4x/vlv

Note that disabling MSI works around the issue, but we can't do that
since apparently then the hw will miss interrupts. At least if
relevant comments in i915_irq.c are accurate.

v2: Cross-reference dp aux and gmbus gen4 comments.

v3: Consolidate harder into i915_drv.h as suggested by Chris.

Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reported-and-tested-by: Jiri Kosina <jkosina@suse.cz>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_drv.h
drivers/gpu/drm/i915/intel_dp.c
drivers/gpu/drm/i915/intel_i2c.c