]> git.baikalelectronics.ru Git - kernel.git/commit
iomap: fix WARN_ON_ONCE() from unprivileged users
authorQian Cai <cai@lca.pw>
Thu, 10 Sep 2020 15:26:15 +0000 (08:26 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Thu, 10 Sep 2020 15:26:15 +0000 (08:26 -0700)
commit2c3c620b18316e0fcb90198c3a346d95e6f3edab
treefc7db90d60dccf7c13ec19455ec2fb0cc4031207
parent9d314c4d53fdbaeff121a0893324d08cb4107329
iomap: fix WARN_ON_ONCE() from unprivileged users

It is trivial to trigger a WARN_ON_ONCE(1) in iomap_dio_actor() by
unprivileged users which would taint the kernel, or worse - panic if
panic_on_warn or panic_on_taint is set. Hence, just convert it to
pr_warn_ratelimited() to let users know their workloads are racing.
Thank Dave Chinner for the initial analysis of the racing reproducers.

Signed-off-by: Qian Cai <cai@lca.pw>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/iomap/direct-io.c