]> git.baikalelectronics.ru Git - kernel.git/commit
media: dvb-usb: m920x: Fix a potential memory leak in m920x_i2c_xfer()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Mon, 29 May 2023 05:58:36 +0000 (07:58 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 13 Sep 2023 07:42:50 +0000 (09:42 +0200)
commit2b6e20ef0585a467c24c7e4fde28518e5b33225a
treeb0c518781d81cecdc9f890e4b5094c84017803b9
parent323ee5fc980bf4ef87f047ee6624dc915d221682
media: dvb-usb: m920x: Fix a potential memory leak in m920x_i2c_xfer()

[ Upstream commit ea9ef6c2e001c5dc94bee35ebd1c8a98621cf7b8 ]

'read' is freed when it is known to be NULL, but not when a read error
occurs.

Revert the logic to avoid a small leak, should a m920x_read() call fail.

Fixes: a2ab06d7c4d6 ("media: m920x: don't use stack on USB reads")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/usb/dvb-usb/m920x.c