]> git.baikalelectronics.ru Git - kernel.git/commit
hv_netvsc: Fix hibernation for mlx5 VF driver
authorDexuan Cui <decui@microsoft.com>
Mon, 7 Sep 2020 07:13:39 +0000 (00:13 -0700)
committerJakub Kicinski <kuba@kernel.org>
Tue, 8 Sep 2020 04:04:36 +0000 (21:04 -0700)
commit2b6365daae19fd0560fc5fdbd4a96409d7c5c9e7
tree9eadcc01a33bb96633c63563d0488f050aa20a9a
parent8cca6aae98d50f1410db93ebb09fbcb8f551404c
hv_netvsc: Fix hibernation for mlx5 VF driver

mlx5_suspend()/resume() keep the network interface, so during hibernation
netvsc_unregister_vf() and netvsc_register_vf() are not called, and hence
netvsc_resume() should call netvsc_vf_changed() to switch the data path
back to the VF after hibernation. Note: after we close and re-open the
vmbus channel of the netvsc NIC in netvsc_suspend() and netvsc_resume(),
the data path is implicitly switched to the netvsc NIC. Similarly,
netvsc_suspend() should not call netvsc_unregister_vf(), otherwise the VF
can no longer be used after hibernation.

For mlx4, since the VF network interafce is explicitly destroyed and
re-created during hibernation (see mlx4_suspend()/resume()), hv_netvsc
already explicitly switches the data path from and to the VF automatically
via netvsc_register_vf() and netvsc_unregister_vf(), so mlx4 doesn't need
this fix. Note: mlx4 can still work with the fix because in
netvsc_suspend()/resume() ndev_ctx->vf_netdev is NULL for mlx4.

Fixes: bde4716514df ("hv_netvsc: Add the support of hibernation")
Signed-off-by: Dexuan Cui <decui@microsoft.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/hyperv/netvsc_drv.c