]> git.baikalelectronics.ru Git - kernel.git/commit
net: rtnl: avoid uninitialized data in IFLA_VF_VLAN_LIST handling
authorArnd Bergmann <arnd@arndb.de>
Fri, 30 Sep 2016 16:13:49 +0000 (18:13 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 3 Oct 2016 05:31:48 +0000 (01:31 -0400)
commit2a5cacc9e6d0e61b983ca15d37893efff98e10bb
tree30bdaa265f90d8bd7319b0db866fd48b63c4df94
parenta6bf650fdb311e81f62936af4698e9408c672b3f
net: rtnl: avoid uninitialized data in IFLA_VF_VLAN_LIST handling

With the newly added support for IFLA_VF_VLAN_LIST netlink messages,
we get a warning about potential uninitialized variable use in
the parsing of the user input when enabling the -Wmaybe-uninitialized
warning:

net/core/rtnetlink.c: In function 'do_setvfinfo':
net/core/rtnetlink.c:1756:9: error: 'ivvl$' may be used uninitialized in this function [-Werror=maybe-uninitialized]

I have not been able to prove whether it is possible to arrive in
this code with an empty IFLA_VF_VLAN_LIST block, but if we do,
then ndo_set_vf_vlan gets called with uninitialized arguments.

This adds an explicit check for an empty list, making it obvious
to the reader and the compiler that this cannot happen.

Fixes: 20235b2144e0 ("net: Update API for VF vlan protocol 802.1ad support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Moshe Shemesh <moshe@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/rtnetlink.c