]> git.baikalelectronics.ru Git - kernel.git/commit
drm/amdgpu: initialize amdgpu_cgs_acpi_eval_object result value
authorNicolas Iooss <nicolas.iooss_linux@m4x.org>
Sat, 18 Jun 2016 20:55:00 +0000 (22:55 +0200)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 20 Jun 2016 21:09:39 +0000 (17:09 -0400)
commit2a01e46ef04d7ac74d20de4cfb757c48d6a48ac8
treea69a89a3769c01493681223959439d5fd310f5e5
parentc5ef8e7cc4e264ae987f4d591d5702f7cf4728d0
drm/amdgpu: initialize amdgpu_cgs_acpi_eval_object result value

amdgpu_cgs_acpi_eval_object() returned the value of variable "result"
without initializing it first.

This bug has been found by compiling the kernel with clang.  The
compiler complained:

    drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:972:14: error: variable
    'result' is used uninitialized whenever 'for' loop exits because its
    condition is false [-Werror,-Wsometimes-uninitialized]
            for (i = 0; i < count; i++) {
                        ^~~~~~~~~
    drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:1011:9: note: uninitialized
    use occurs here
            return result;
                   ^~~~~~
    drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:972:14: note: remove the
    condition if it is always true
            for (i = 0; i < count; i++) {
                        ^~~~~~~~~
    drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c:864:12: note: initialize the
    variable 'result' to silence this warning
            int result;
                      ^
                       = 0

Fixes: a91371f54471 ("drm/amdgpu: implement new cgs interface for acpi
function")
Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org>
Cc: stable@vger.kernel.org
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c