]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "net/mlx5e: Enable reporting checksum unnecessary also for L3 packets"
authorOr Gerlitz <ogerlitz@mellanox.com>
Sun, 31 Mar 2019 12:53:03 +0000 (12:53 +0000)
committerSaeed Mahameed <saeedm@mellanox.com>
Tue, 9 Apr 2019 19:33:51 +0000 (12:33 -0700)
commit2945afcd1cd0cb69153946355220cd3ab332b19b
tree40fc193ad6448b3f4ca2b61a1969ca28a5900773
parent62a37274d0cc4768e331b0341a483c120398fa98
Revert "net/mlx5e: Enable reporting checksum unnecessary also for L3 packets"

This reverts commit 7868234539c60d06959054926ef3f3d553415314.

Prior the commit we are reverting, checksum unnecessary was only set when
both the L3 OK and L4 OK bits are set on the CQE. This caused packets
of IP protocols such as SCTP which are not dealt by the current HW L4
parser (hence the L4 OK bit is not set, but the L4 header type none bit
is set) to go through the checksum none code, where currently we wrongly
report checksum unnecessary for them, a regression. Fix this by a revert.

Note that on our usual track we report checksum complete, so the revert
isn't expected to have any notable performance impact. Also, when we are
not on the checksum complete track, the L4 protocols for which we report
checksum none are not high performance ones, we will still report
checksum unnecessary for UDP/TCP.

Fixes: 7868234539c6 ("net/mlx5e: Enable reporting checksum unnecessary also for L3 packets")
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Reported-by: Avi Urman <aviu@mellanox.com>
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
drivers/net/ethernet/mellanox/mlx5/core/en_rx.c