]> git.baikalelectronics.ru Git - kernel.git/commit
ublk_drv: fix build warning with -Wmaybe-uninitialized and one sparse warning
authorMing Lei <ming.lei@redhat.com>
Sat, 16 Jul 2022 09:53:44 +0000 (17:53 +0800)
committerJens Axboe <axboe@kernel.dk>
Sat, 16 Jul 2022 12:32:48 +0000 (06:32 -0600)
commit291defff548ea074980ec6de32964985b2eeb2ca
tree785d4f0a0122b3de0199e15795e4925086fdc01a
parent325e3fe05e1c49749c304e5ffae6ab84df3599b9
ublk_drv: fix build warning with -Wmaybe-uninitialized and one sparse warning

After applying -Wmaybe-uninitialized manually, two build warnings are
triggered:

drivers/block/ublk_drv.c:940:11: warning: ‘io’ may be used uninitialized [-Wmaybe-uninitialized]
  940 |         io->flags &= ~UBLK_IO_FLAG_ACTIVE;

drivers/block/ublk_drv.c: In function ‘ublk_ctrl_uring_cmd’:
drivers/block/ublk_drv.c:1531:9: warning: ‘ret’ may be used uninitialized [-Wmaybe-uninitialized]

Fix the 1st one by removing 'io->flags &= ~UBLK_IO_FLAG_ACTIVE;' which
isn't needed since the function always return successfully after setting
this flag.

Fix the 2nd one by always initializing 'ret'.

Also fix another sparse warning of 'sparse: sparse: incorrect type in return
expression' by changing return type of ublk_setup_iod().

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20220716095344.222674-1-ming.lei@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/ublk_drv.c