]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Compute the HWS offsets explicitly
authorChris Wilson <chris@chris-wilson.co.uk>
Fri, 25 Jan 2019 12:00:05 +0000 (12:00 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Fri, 25 Jan 2019 12:53:15 +0000 (12:53 +0000)
commit28362f24558a9842b8b347f640a903c761e4bf3a
tree0b9c4501c9c2a37d715e97848c83d1ad11638f91
parentfec752721858c602cc2c5bbbb61a38daa6252ff6
drm/i915: Compute the HWS offsets explicitly

Simplify by using sizeof(u32) to convert from the index inside the HWSP
to the byte offset. This has the advantage of not only being shorter
(and so not upsetting checkpatch!) but that it matches use where we are
writing to byte addresses using other commands than MI_STORE_DWORD_IMM.

v2: Drop the now superfluous MI_STORE_DWORD_INDEX_SHIFT, it appears to
be a local invention so keeping it after the final use does not help to
clarify the GPU instruction.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190125120005.25191-2-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/intel_gpu_commands.h
drivers/gpu/drm/i915/intel_guc_submission.c
drivers/gpu/drm/i915/intel_ringbuffer.h