]> git.baikalelectronics.ru Git - kernel.git/commit
netfilter: bridge: Use __in6_dev_get rather than in6_dev_get in br_validate_ipv6
authorJulien Grall <julien.grall@citrix.com>
Tue, 7 Jul 2015 14:55:21 +0000 (15:55 +0100)
committerPablo Neira Ayuso <pablo@netfilter.org>
Wed, 8 Jul 2015 09:02:16 +0000 (11:02 +0200)
commit28182fea2317d6ede9c22a56f5fd7477d3df8ae5
treebab4f3db9039c9d9db5b9b2e31eef70c8719104a
parent4252ca441a7f70bbe585a3da6e9e64d92cf1560e
netfilter: bridge: Use __in6_dev_get rather than in6_dev_get in br_validate_ipv6

The commit 46d1316b8c02724d2ecc1379ed6914b28959315d "netfilter: bridge:
forward IPv6 fragmented packets" introduced a new function
br_validate_ipv6 which take a reference on the inet6 device. Although,
the reference is not released at the end.

This will result to the impossibility to destroy any netdevice using
ipv6 and bridge.

It's possible to directly retrieve the inet6 device without taking a
reference as all netfilter hooks are protected by rcu_read_lock via
nf_hook_slow.

Spotted while trying to destroy a Xen guest on the upstream Linux:
"unregister_netdevice: waiting for vif1.0 to become free. Usage count = 1"

Signed-off-by: Julien Grall <julien.grall@citrix.com>
Cc: Bernhard Thaler <bernhard.thaler@wvnet.at>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: fw@strlen.de
Cc: ian.campbell@citrix.com
Cc: wei.liu2@citrix.com
Cc: Bob Liu <bob.liu@oracle.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/bridge/br_netfilter_ipv6.c