]> git.baikalelectronics.ru Git - kernel.git/commit
md/raid10: fix bug when raid10 recovery fails to recover a block.
authorNeilBrown <neilb@suse.de>
Sun, 5 Jan 2014 23:35:34 +0000 (10:35 +1100)
committerNeilBrown <neilb@suse.de>
Tue, 14 Jan 2014 05:44:08 +0000 (16:44 +1100)
commit27dda10e915110fdd5b1b22a34504dfa91263c7c
tree774d35e3f97ebc4f7a4b200c2f99f961afa7e1df
parent6b3c9ee6982d351d8532b45717c46723460add0a
md/raid10: fix bug when raid10 recovery fails to recover a block.

commit f035dcc4119c35671fb18f33e4a03ab0c02ff82d
    md/raid10 record bad blocks as needed during recovery.

added code to the "cannot recover this block" path to record a bad
block rather than fail the whole recovery.
Unfortunately this new case was placed *after* r10bio was freed rather
than *before*, yet it still uses r10bio.
This is will crash with a null dereference.

So move the freeing of r10bio down where it is safe.

Cc: stable@vger.kernel.org (v3.1+)
Fixes: f035dcc4119c35671fb18f33e4a03ab0c02ff82d
Reported-by: Damian Nowak <spam@nowaker.net>
URL: https://bugzilla.kernel.org/show_bug.cgi?id=68181
Signed-off-by: NeilBrown <neilb@suse.de>
drivers/md/raid10.c