]> git.baikalelectronics.ru Git - kernel.git/commit
net: dsa: mv88e6xxx: handle unknown duplex modes gracefully in mv88e6xxx_port_set_duplex
authorHeiner Kallweit <hkallweit1@gmail.com>
Fri, 1 Mar 2019 18:53:57 +0000 (19:53 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 4 Mar 2019 05:03:28 +0000 (21:03 -0800)
commit27d3e1df13a62e69ac180959932ba8f5d1d96da1
tree9c47fa22198cba80aec31ad558b6823861f79956
parentbb35e988b1169bfbb12ae7442b2739ae8f494609
net: dsa: mv88e6xxx: handle unknown duplex modes gracefully in mv88e6xxx_port_set_duplex

When testing another issue I faced the problem that
mv88e6xxx_port_setup_mac() failed due to DUPLEX_UNKNOWN being passed
as argument to mv88e6xxx_port_set_duplex(). We should handle this case
gracefully and return -EOPNOTSUPP, like e.g. mv88e6xxx_port_set_speed()
is doing it.

Fixes: 906f6f5b7155 ("net: dsa: mv88e6xxx: add port duplex setter")
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/mv88e6xxx/port.c