]> git.baikalelectronics.ru Git - kernel.git/commit
net/mlx5e: Avoid implicit modify hdr for decap drop rule
authorRoi Dayan <roid@nvidia.com>
Tue, 1 Feb 2022 13:27:48 +0000 (15:27 +0200)
committerSaeed Mahameed <saeedm@nvidia.com>
Wed, 2 Feb 2022 04:59:43 +0000 (20:59 -0800)
commit27c2067ef3269daebe697ebfa3e33951ade73a5e
tree3f44a7f0820c8c7d06918713e25574e3e8b4f292
parent18365e1e008cbfda192b37e6c0aaf3d3eefbb391
net/mlx5e: Avoid implicit modify hdr for decap drop rule

Currently the driver adds implicit modify hdr action for
decap rules on tunnel devices if the port is an ovs port.
This is also done if the action is drop and makes the modify
hdr redundant and also the FW doesn't support it and will generate
a syndrome.

kernel: mlx5_core 0000:08:00.0: mlx5_cmd_check:777:(pid 102063): SET_FLOW_TABLE_ENTRY(0x936) op_mod(0x0) failed, status bad parameter(0x3), syndrome (0x8708c3)

Fix it by adding the implicit modify hdr only for fwd actions.

Fixes: e94cae3b4c31 ("net/mlx5: Support internal port as decap route device")
Fixes: 84b1abd99484 ("net/mlx5e: TC, Fix memory leak with rules with internal port")
Signed-off-by: Roi Dayan <roid@nvidia.com>
Reviewed-by: Ariel Levkovich <lariel@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c