]> git.baikalelectronics.ru Git - kernel.git/commit
KVM: x86/mmu: Don't rebuild page when the page is synced and no tlb flushing is required
authorHou Wenlong <houwenlong.hwl@antgroup.com>
Tue, 15 Mar 2022 09:35:13 +0000 (17:35 +0800)
committerPaolo Bonzini <pbonzini@redhat.com>
Sat, 2 Apr 2022 09:44:23 +0000 (05:44 -0400)
commit278427b72cc4a2e67fedd56c4d3e0d8e57a5d150
tree1e52a6c26852eb00dbfd48fbdd3ef298c8c95de3
parentdffe2a135514e2dcc6c04c04eb0d57a9cb04bd29
KVM: x86/mmu: Don't rebuild page when the page is synced and no tlb flushing is required

Before Commit 32f7c9f979226 ("KVM: X86: Change kvm_sync_page()
to return true when remote flush is needed"), the return value
of kvm_sync_page() indicates whether the page is synced, and
kvm_mmu_get_page() would rebuild page when the sync fails.
But now, kvm_sync_page() returns false when the page is
synced and no tlb flushing is required, which leads to
rebuild page in kvm_mmu_get_page(). So return the return
value of mmu->sync_page() directly and check it in
kvm_mmu_get_page(). If the sync fails, the page will be
zapped and the invalid_list is not empty, so set flush as
true is accepted in mmu_sync_children().

Cc: stable@vger.kernel.org
Fixes: 32f7c9f979226 ("KVM: X86: Change kvm_sync_page() to return true when remote flush is needed")
Signed-off-by: Hou Wenlong <houwenlong.hwl@antgroup.com>
Acked-by: Lai Jiangshan <jiangshanlai@gmail.com>
Message-Id: <0dabeeb789f57b0d793f85d073893063e692032d.1647336064.git.houwenlong.hwl@antgroup.com>
[mmu_sync_children should not flush if the page is zapped. - Paolo]
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/mmu/mmu.c