]> git.baikalelectronics.ru Git - kernel.git/commit
bnx2x: really disable TPA if 'disable_tpa' option is set
authorMichal Schmidt <mschmidt@redhat.com>
Mon, 27 Apr 2015 15:20:38 +0000 (17:20 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 27 Apr 2015 17:42:39 +0000 (13:42 -0400)
commit2749728f7f6296878c32ccb2ca8ed5dbbb938749
treedcf7a9c4c678f20cbaa3d5201b8ae668eac10d6e
parentf49057e5710041bf977c8797b0292bac9a0eeec0
bnx2x: really disable TPA if 'disable_tpa' option is set

bnx2x's 'disable_tpa=1' module option is not respected properly and TPA
(transparent packet aggregation) remains enabled. Even though the
module option causes LRO to be disabled, TPA is enabled in GRO mode.

Additionally, disabling GRO via ethtool then has no effect. One can
still observe tpa_* statistics increase and large packets being received
in tcpdump.

The bug was an unintended consequence of commit 24389eeb7a48 "bnx2x: Be
more forgiving toward SW GRO".

Fix it by following the bp->disable_tpa flag when initializing fp's.

Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c