]> git.baikalelectronics.ru Git - kernel.git/commit
ASoC: msm8916-wcd-analog: Fix RX1 selection in RDAC2 MUX
authorStephan Gerhold <stephan@gerhold.net>
Sun, 20 Oct 2019 15:30:06 +0000 (17:30 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 21 Oct 2019 12:50:01 +0000 (13:50 +0100)
commit26d038026d1f9a3e1310fed28f7653594cc8241d
tree016f0b4a34a645c61758b57e5073835999d72177
parent44b17bcef818eb967e8817c30ae19eed86637b01
ASoC: msm8916-wcd-analog: Fix RX1 selection in RDAC2 MUX

According to the PM8916 Hardware Register Description,
CDC_D_CDC_CONN_HPHR_DAC_CTL has only a single bit (RX_SEL)
to switch between RX1 (0) and RX2 (1). It is not possible to
disable it entirely to achieve the "ZERO" state.

However, at the moment the "RDAC2 MUX" mixer defines three possible
values ("ZERO", "RX2" and "RX1"). Setting the mixer to "ZERO"
actually configures it to RX1. Setting the mixer to "RX1" has
(seemingly) no effect.

Remove "ZERO" and replace it with "RX1" to fix this.

Fixes: 1e90dab1850e ("ASoC: codecs: Add msm8916-wcd analog codec")
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20191020153007.206070-1-stephan@gerhold.net
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/msm8916-wcd-analog.c