]> git.baikalelectronics.ru Git - kernel.git/commit
s390/vdso: fix tod_steering_delta type
authorHeiko Carstens <hca@linux.ibm.com>
Wed, 24 Mar 2021 19:22:42 +0000 (20:22 +0100)
committerHeiko Carstens <hca@linux.ibm.com>
Thu, 25 Mar 2021 20:57:25 +0000 (21:57 +0100)
commit269fe790a5c33fba098ea415cada9332d1af5021
tree08b4bfe87aa4290c00da7d3e185ae3f3747ebf41
parentfeea048cf251e72b09ec169440d0c4cc46a43e13
s390/vdso: fix tod_steering_delta type

The s390 specific vdso function __arch_get_hw_counter() is supposed to
consider tod clock steering.

If a tod clock steering event happens and the tod clock is set to a
new value __arch_get_hw_counter() will not return the real tod clock
value but slowly drift it from the old delta until the returned value
finally matches the real tod clock value again.

Unfortunately the type of tod_steering_delta unsigned while it is
supposed to be signed. It depends on if tod_steering_delta is negative
or positive in which direction the vdso code drifts the clock value.

Worst case is now that instead of drifting the clock slowly it will
jump into the opposite direction by a factor of two.

Fix this by simply making tod_steering_delta signed.

Fixes: 45ce54937694 ("s390: convert to GENERIC_VDSO")
Cc: <stable@vger.kernel.org> # 5.10
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
arch/s390/include/asm/vdso/data.h