]> git.baikalelectronics.ru Git - kernel.git/commit
drivers/net/ethernet/mellanox/mlx4/mcg.c: fix error return code
authorJulia Lawall <Julia.Lawall@lip6.fr>
Tue, 14 Aug 2012 02:58:34 +0000 (02:58 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 15 Aug 2012 00:00:57 +0000 (17:00 -0700)
commit266d77baf259ddb38752e9b7861684c58c169d59
tree40f3cc4834a51a90ddea79d47137cee2d9fb3bda
parent6e13b44a0092fa4bd3e9dccbc0b703a9da3be718
drivers/net/ethernet/mellanox/mlx4/mcg.c: fix error return code

Convert a 0 error return code to a negative one, as returned elsewhere in the
function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier ret;
expression e,e1,e2,e3,e4,x;
@@

(
if (\(ret != 0\|ret < 0\) || ...) { ... return ...; }
|
ret = 0
)
... when != ret = e1
*x = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\|ioremap\|ioremap_nocache\|devm_ioremap\|devm_ioremap_nocache\)(...);
... when != x = e2
    when != ret = e3
*if (x == NULL || ...)
{
  ... when != ret = e4
*  return ret;
}
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx4/mcg.c