]> git.baikalelectronics.ru Git - kernel.git/commit
mmmremap.c: avoid pointless invalidate_range_start/end on mremap(old_size=0)
authorPaolo Bonzini <pbonzini@redhat.com>
Fri, 8 Apr 2022 20:09:04 +0000 (13:09 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sat, 9 Apr 2022 00:20:36 +0000 (14:20 -1000)
commit258d2d98a19054de2af4bf891be8e7c8ea5c3197
treec6bb531bdfd0459b88e2777ca429dfe0cb666df5
parent6d6dbd62f5758c7ee2006fe4091681bd94a28896
mmmremap.c: avoid pointless invalidate_range_start/end on mremap(old_size=0)

If an mremap() syscall with old_size=0 ends up in move_page_tables(), it
will call invalidate_range_start()/invalidate_range_end() unnecessarily,
i.e.  with an empty range.

This causes a WARN in KVM's mmu_notifier.  In the past, empty ranges
have been diagnosed to be off-by-one bugs, hence the WARNing.  Given the
low (so far) number of unique reports, the benefits of detecting more
buggy callers seem to outweigh the cost of having to fix cases such as
this one, where userspace is doing something silly.  In this particular
case, an early return from move_page_tables() is enough to fix the
issue.

Link: https://lkml.kernel.org/r/20220329173155.172439-1-pbonzini@redhat.com
Reported-by: syzbot+6bde52d89cfdf9f61425@syzkaller.appspotmail.com
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Cc: Sean Christopherson <seanjc@google.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/mremap.c