]> git.baikalelectronics.ru Git - kernel.git/commit
ixgbe: pci_set_drvdata must be called before register_netdev
authorJeff Mahoney <jeffm@suse.com>
Sat, 3 Jun 2017 22:01:17 +0000 (18:01 -0400)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Wed, 14 Jun 2017 00:36:39 +0000 (17:36 -0700)
commit252254ba9409b2835a7f80bcb8fbb50bcd1a5a7c
treed1fdef3e135eca0fc54540449018f12f190f615a
parentdf68633ecd438a5104a8fdc251ff8e99fb96f3d5
ixgbe: pci_set_drvdata must be called before register_netdev

We call pci_set_drvdata immediately after calling register_netdev,
which leaves a window where tasks writing to the sriov_numvfs sysfs
attribute can sneak in and crash the kernel.  register_netdev cleans
up after itself so placing pci_set_drvdata immediately before it
should preserve the intent of commit 15e2343db3eb ("ixgbe: fix crash
on rmmod after probe fail").

Fixes: 15e2343db3eb ("ixgbe: fix crash on rmmod after probe fail")
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c