]> git.baikalelectronics.ru Git - kernel.git/commit
nvmet: fix uninitialized work for zero kato
authorzhenwei pi <pizhenwei@bytedance.com>
Thu, 15 Oct 2020 01:51:40 +0000 (09:51 +0800)
committerChristoph Hellwig <hch@lst.de>
Thu, 22 Oct 2020 13:27:14 +0000 (15:27 +0200)
commit23ae10b3138e7bf449739b10ea85c939850141d1
tree4f16e83095213637f252cf499b90ecf450afe0e5
parent7536c0af47ca690386f6ebe1caec26045cedfe5c
nvmet: fix uninitialized work for zero kato

When connecting a controller with a zero kato value using the following
command line

   nvme connect -t tcp -n NQN -a ADDR -s PORT --keep-alive-tmo=0

the warning below can be reproduced:

WARNING: CPU: 1 PID: 241 at kernel/workqueue.c:1627 __queue_delayed_work+0x6d/0x90
with trace:
  mod_delayed_work_on+0x59/0x90
  nvmet_update_cc+0xee/0x100 [nvmet]
  nvmet_execute_prop_set+0x72/0x80 [nvmet]
  nvmet_tcp_try_recv_pdu+0x2f7/0x770 [nvmet_tcp]
  nvmet_tcp_io_work+0x63f/0xb2d [nvmet_tcp]
  ...

This is caused by queuing up an uninitialized work.  Althrough the
keep-alive timer is disabled during allocating the controller (fixed in
43d3947a66f5), ka_work still has a chance to run (called by
nvmet_start_ctrl).

Fixes: 43d3947a66f5 ("nvmet: Disable keep-alive timer when kato is cleared to 0h")
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/target/core.c