]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "macsec: missing dev_put() on error in macsec_newlink()"
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 16 Apr 2018 10:17:50 +0000 (13:17 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 16 Apr 2018 14:01:12 +0000 (10:01 -0400)
commit237dffdb4e3cd7369fa7cfe618aac12ed430c4b7
treefcfed1bd77ffee1353967ac7aae1952ec327c1fc
parent558bb37b19227b63a11caff709eebeb276873ca5
Revert "macsec: missing dev_put() on error in macsec_newlink()"

This patch is just wrong, sorry.  I was trying to fix a static checker
warning and misread the code.  The reference taken in macsec_newlink()
is released in macsec_free_netdev() when the netdevice is destroyed.

This reverts commit 8d38f14b34766f8d3872c2766e1f135f61cb0357.

Reported-by: Laura Abbott <labbott@redhat.com>
Fixes: 8d38f14b3476 ("macsec: missing dev_put() on error in macsec_newlink()")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/macsec.c