]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915/gem: Store mmap_offsets in an rbtree rather than a plain list
authorChris Wilson <chris@chris-wilson.co.uk>
Mon, 20 Jan 2020 10:49:22 +0000 (10:49 +0000)
committerJani Nikula <jani.nikula@intel.com>
Tue, 11 Feb 2020 09:49:31 +0000 (11:49 +0200)
commit23438aa5c4c88fbc16716bad068aa77aa64b16d3
tree2ce00ad8a95c698dadb75c41c30adfd7542f0db0
parent0fbe7054845c7bb46ea32c9419fb84ea6b586a2f
drm/i915/gem: Store mmap_offsets in an rbtree rather than a plain list

Currently we create a new mmap_offset for every call to
mmap_offset_ioctl. This exposes ourselves to an abusive client that may
simply create new mmap_offsets ad infinitum, which will exhaust physical
memory and the virtual address space. In addition to the exhaustion, a
very long linear list of mmap_offsets causes other clients using the
object to incur long list walks -- these long lists can also be
generated by simply having many clients generate their own mmap_offset.

However, we can simply use the drm_vma_node itself to manage the file
association (allow/revoke) dropping our need to keep an mmo per-file.
Then if we keep a small rbtree of per-type mmap_offsets, we can lookup
duplicate requests quickly.

Fixes: 7691c426d118 ("drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
Reviewed-by: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200120104924.4000706-3-chris@chris-wilson.co.uk
(cherry picked from commit 7865559872074a9ab169c87915504661d630addf)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/gem/i915_gem_mman.c
drivers/gpu/drm/i915/gem/i915_gem_object.c
drivers/gpu/drm/i915/gem/i915_gem_object_types.h