]> git.baikalelectronics.ru Git - kernel.git/commit
vxlan: Don't call gro_cells_destroy() before device is unregistered
authorZhiqiang Liu <liuzhiqiang26@huawei.com>
Sat, 16 Mar 2019 09:02:54 +0000 (17:02 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 19 Mar 2019 00:07:27 +0000 (17:07 -0700)
commit2269b0f115d3a8b725b4cdd1d0e4ef0c5bb2603f
tree97cbca43b015f1d37d89c5a2a4ffeccdaa75e19a
parent325eb2b94f8fc9610058bcbc858973d703d59fa8
vxlan: Don't call gro_cells_destroy() before device is unregistered

Commit 81e48eca1a654 ("vxlan: Fix GRO cells race condition between
receive and link delete") fixed a race condition for the typical case a vxlan
device is dismantled from the current netns. But if a netns is dismantled,
vxlan_destroy_tunnels() is called to schedule a unregister_netdevice_queue()
of all the vxlan tunnels that are related to this netns.

In vxlan_destroy_tunnels(), gro_cells_destroy() is called and finished before
unregister_netdevice_queue(). This means that the gro_cells_destroy() call is
done too soon, for the same reasons explained in above commit.

So we need to fully respect the RCU rules, and thus must remove the
gro_cells_destroy() call or risk use after-free.

Fixes: e57059e63184 ("vxlan: GRO support at tunnel layer")
Signed-off-by: Suanming.Mou <mousuanming@huawei.com>
Suggested-by: Eric Dumazet <eric.dumazet@gmail.com>
Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/vxlan.c