i2c: cpm: Fix i2c_ram structure
authorNicolas VINCENT <nicolas.vincent@vossloh.com>
Wed, 23 Sep 2020 14:08:40 +0000 (16:08 +0200)
committerWolfram Sang <wsa@kernel.org>
Sun, 27 Sep 2020 13:14:16 +0000 (15:14 +0200)
commit21581e72e86989902d46b6d4a16ad2b9aca1a2b4
tree0c772f466cf095e928ce1801e0e16edcc699e6c6
parent4680cfc9e6e037fb13e183d0ff0c6d6616f0c5bf
i2c: cpm: Fix i2c_ram structure

the i2c_ram structure is missing the sdmatmp field mentionned in
datasheet for MPC8272 at paragraph 36.5. With this field missing, the
hardware would write past the allocated memory done through
cpm_muram_alloc for the i2c_ram structure and land in memory allocated
for the buffers descriptors corrupting the cbd_bufaddr field. Since this
field is only set during setup(), the first i2c transaction would work
and the following would send data read from an arbitrary memory
location.

Fixes: 42d8e2fdb923 ("i2c: Add support for I2C bus on Freescale CPM1/CPM2 controllers")
Signed-off-by: Nicolas VINCENT <nicolas.vincent@vossloh.com>
Acked-by: Jochen Friedrich <jochen@scram.de>
Acked-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
drivers/i2c/busses/i2c-cpm.c