]> git.baikalelectronics.ru Git - kernel.git/commit
drm/vmwgfx: Fix double free in vmw_recv_msg()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 15 Aug 2019 08:30:50 +0000 (11:30 +0300)
committerThomas Hellstrom <thellstrom@vmware.com>
Thu, 5 Sep 2019 12:44:28 +0000 (14:44 +0200)
commit1f02c28b75894ca4597b1d22d8f7cf3e65d206fb
tree16cd884489ffb829e38ff94650adb5f522bdc6c9
parent06d283121dac4a0253d554f7c694b703e18490b1
drm/vmwgfx: Fix double free in vmw_recv_msg()

We recently added a kfree() after the end of the loop:

if (retries == RETRIES) {
kfree(reply);
return -EINVAL;
}

There are two problems.  First the test is wrong and because retries
equals RETRIES if we succeed on the last iteration through the loop.
Second if we fail on the last iteration through the loop then the kfree
is a double free.

When you're reading this code, please note the break statement at the
end of the while loop.  This patch changes the loop so that if it's not
successful then "reply" is NULL and we can test for that afterward.

Cc: <stable@vger.kernel.org>
Fixes: 06d283121dac ("drm/vmwgfx: fix memory leak when too many retries have occurred")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
drivers/gpu/drm/vmwgfx/vmwgfx_msg.c