]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Fix logic fumble in rotation vs. ccs check
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Tue, 18 Sep 2018 13:10:59 +0000 (16:10 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Tue, 18 Sep 2018 15:12:12 +0000 (18:12 +0300)
commit1ee516ffa73107f96c1355cce5880b6c38d22d51
tree3e4bff2ca91491c68c59de9f0ad4a071182aa612
parent21c62a9d16252725ec1f26707bf7db6b8ec59c7f
drm/i915: Fix logic fumble in rotation vs. ccs check

Smatch reports:
../drivers/gpu/drm/i915/intel_sprite.c:1192 skl_plane_check_fb() warn: was || intended here instead of &&?

Obviously smatch is correct here since we're trying to check if we're
using either of the ccs modifiers. Since we now have is_ccs_modifier()
let's use it to fix this.

Cc: Dan Carpenter <dan.carpenter@oracle.com>
Cc: José Roberto de Souza <jose.souza@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: e21c2d331018 ("drm/i915: Move skl plane fb related checks into a better place")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180918131059.793-1-ville.syrjala@linux.intel.com
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
drivers/gpu/drm/i915/intel_sprite.c