]> git.baikalelectronics.ru Git - kernel.git/commit
scsi: sg: recheck MMAP_IO request length with lock held
authorTodd Poynor <toddpoynor@google.com>
Wed, 16 Aug 2017 04:48:43 +0000 (21:48 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 25 Aug 2017 02:29:08 +0000 (22:29 -0400)
commit1df875e81e528bc28847a313ebb9330a07f16bd8
tree650ba5571bc1f888b0ef6220cccfae2f114b12a5
parent9c865e9b22bafbebca076635e55f314d060b5ed4
scsi: sg: recheck MMAP_IO request length with lock held

Commit 63157c1f95e1 ("scsi: sg: protect accesses to 'reserved' page
array") adds needed concurrency protection for the "reserve" buffer.
Some checks that are initially made outside the lock are replicated once
the lock is taken to ensure the checks and resulting decisions are made
using consistent state.

The check that a request with flag SG_FLAG_MMAP_IO set fits in the
reserve buffer also needs to be performed again under the lock to ensure
the reserve buffer length compared against matches the value in effect
when the request is linked to the reserve buffer.  An -ENOMEM should be
returned in this case, instead of switching over to an indirect buffer
as for non-MMAP_IO requests.

Signed-off-by: Todd Poynor <toddpoynor@google.com>
Acked-by: Douglas Gilbert <dgilbert@interlog.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/sg.c