]> git.baikalelectronics.ru Git - kernel.git/commit
net: aquantia: memory corruption on jumbo frames
authorFriedemann Gerold <f.gerold@b-c-s.de>
Sat, 15 Sep 2018 15:03:39 +0000 (18:03 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 17 Sep 2018 15:14:14 +0000 (08:14 -0700)
commit1de42e35bae1e07b0c37402e0f957aada0079fe4
tree2d3785f67b8784f51a8986a07442252cd4fd7f32
parentd71efe355a3c333160052055fc01ed13e3cc5895
net: aquantia: memory corruption on jumbo frames

This patch fixes skb_shared area, which will be corrupted
upon reception of 4K jumbo packets.

Originally build_skb usage purpose was to reuse page for skb to eliminate
needs of extra fragments. But that logic does not take into account that
skb_shared_info should be reserved at the end of skb data area.

In case packet data consumes all the page (4K), skb_shinfo location
overflows the page. As a consequence, __build_skb zeroed shinfo data above
the allocated page, corrupting next page.

The issue is rarely seen in real life because jumbo are normally larger
than 4K and that causes another code path to trigger.
But it 100% reproducible with simple scapy packet, like:

    sendp(IP(dst="192.168.100.3") / TCP(dport=443) \
          / Raw(RandString(size=(4096-40))), iface="enp1s0")

Fixes: 87a722383388 ("net: ethernet: aquantia: Add ring support code")
Reported-by: Friedemann Gerold <f.gerold@b-c-s.de>
Reported-by: Michael Rauch <michael@rauch.be>
Signed-off-by: Friedemann Gerold <f.gerold@b-c-s.de>
Tested-by: Nikita Danilov <nikita.danilov@aquantia.com>
Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/aquantia/atlantic/aq_ring.c