]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: Register debugfs interface last
authorChris Wilson <chris@chris-wilson.co.uk>
Fri, 24 Jun 2016 13:00:17 +0000 (14:00 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Fri, 24 Jun 2016 13:43:36 +0000 (14:43 +0100)
commit1dac891c1c95a8528f3558b481fbb9a45d653619
treeb06af0f000bf49d4a011a67e17c0946e463b05fa
parent843152b4b9866a1a3b9db4d866cc6e99b10f7e57
drm/i915: Register debugfs interface last

Currently debugfs files are created before the driver is even loads.
This gives the opportunity for userspace to open that interface and poke
around before the backing data structures are initialised - with the
possibility of oopsing or worse.

Move the creation of the debugfs files to our registration phase, where
we announce our presence to the world when we are ready, i.e the
sequence changes from

drm_dev_register()
 -> drm_minor_register()
  -> drm_debugfs_init()
   -> i915_debugfs_init()
 -> i915_driver_load()

to

drm_dev_register()
 -> drm_minor_register()
  -> drm_debugfs_init()
 -> i915_driver_load()
  -> i915_debugfs_register()

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1466773227-7994-5-git-send-email-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/i915_debugfs.c
drivers/gpu/drm/i915/i915_dma.c
drivers/gpu/drm/i915/i915_drv.c
drivers/gpu/drm/i915/i915_drv.h