]> git.baikalelectronics.ru Git - kernel.git/commit
arm64: dts: marvell: add unique identifiers for Armada A8k SPI controllers
authorMarcin Wojtas <mw@semihalf.com>
Tue, 8 Nov 2016 16:31:32 +0000 (17:31 +0100)
committerGregory CLEMENT <gregory.clement@free-electrons.com>
Wed, 9 Nov 2016 08:44:08 +0000 (09:44 +0100)
commit1d8e4d1e106ece3eb687b59ec2474b5f6f0e3b96
tree8d505155d266780d1cc2e2a78440661ba68fd390
parentde004a1b7a37851ae763fe1366a1fb71ac6a1be0
arm64: dts: marvell: add unique identifiers for Armada A8k SPI controllers

Enabling SPI controllers, which are attached to different busses
inside an SoC, may result in overlapping enumeration and cause
sysfs registration failure. Example log after enabling two
controllers on Armada 8040 SoC with same identifiers:

[    3.740415] sysfs: cannot create duplicate filename
'/class/spi_master/spi0'
[    3.747510] ------------[ cut here ]------------
[    3.752145] WARNING: at fs/sysfs/dir.c:31
[...]
[    4.002299] orion_spi: probe of f4700600.spi failed with error -17

spi-orion driver offers dedicated DT property ('cell-index'), that
allow setting unique identifiers. Recently added support for CP110-slave
HW block introduced two new SPI controllers' nodes with same ID as
ones from CP110-master.

This commit fixes the issue by assigning different 'cell-index' values
for CP110-slave SPI controllers.

Fixes: 5a1c0a7346c5 ("arm64: dts: marvell: add description for the slave
CP110 in Armada 8K")

Signed-off-by: Marcin Wojtas <mw@semihalf.com>
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
arch/arm64/boot/dts/marvell/armada-cp110-slave.dtsi