]> git.baikalelectronics.ru Git - kernel.git/commit
IB/mlx5: Fix XRC QP support after introducing extended atomic
authorYonatan Cohen <yonatanc@mellanox.com>
Wed, 21 Nov 2018 11:48:39 +0000 (13:48 +0200)
committerJason Gunthorpe <jgg@mellanox.com>
Wed, 21 Nov 2018 21:15:14 +0000 (14:15 -0700)
commit1d51fa57b9d81781db8ed1dedae54f5aa42a9fda
tree85e3847d506839768ad19863272b261456b0005e
parent25daf1382ccf8a3d18c97049dd43755108ed4d07
IB/mlx5: Fix XRC QP support after introducing extended atomic

Extended atomics are supported with RC and XRC QP types, but the commit
citied in the Fixes line added an unneeded check to
to_mlx5_access_flags. This broke XRC QPs.

The following ib_atomic_bw invocation over XRC reproduces the issue:
   ib_atomic_bw -d mlx5_1 --connection=XRC --atomic_type=FETCH_AND_ADD

It is safe to remove such checks because the QP type was already checked
in ib_modify_qp_is_ok(), which was previously called from
mlx5_ib_modify_qp.

Fixes: 5b20122c415b ("IB/mlx5: Add support for extended atomic operations")
Signed-off-by: Yonatan Cohen <yonatanc@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/mlx5/qp.c